RavenDB-5652 WIP #1265

myarichuk · 2017-01-03T18:00:31Z

the task is not finished yet, this PR is for purpose of not straying too far from the main branch

…B-5652-proper

ppekrol · 2017-01-03T21:18:51Z

src/Raven.Client/Properties/VersionInfo.cs

@@ -2,7 +2,7 @@
 using System.Linq;
 using System.Reflection;

-[assembly: Raven.Client.RavenVersion(Build = "40", CommitHash = "fd4539d", Version = "4.0", FullVersion = "4.0.0-custom-40")]
+[assembly: Raven.Client.RavenVersion(Build = "40", CommitHash = "a0c3e30", Version = "4.0", FullVersion = "4.0.0-custom-40")]


That is generated by the build.ps1

ppekrol · 2017-01-03T21:19:22Z

src/Raven.Client/Replication/Messages/ReplicationMessageReply.cs

@@ -24,6 +24,8 @@ public enum ReplyType
        public ChangeVectorEntry[] DocumentsChangeVector { get; set; }

        public ChangeVectorEntry[] IndexTransformerChangeVector { get; set; }
+
+        public string DbId { get; set; }


in many places it is called DatabaseId, rename it?

ppekrol · 2017-01-03T21:21:51Z

src/Raven.NewClient/Properties/VersionInfo.cs

@@ -2,7 +2,7 @@
 using System.Linq;
 using System.Reflection;

-[assembly: Raven.NewClient.RavenVersion(Build = "40", CommitHash = "fd4539d", Version = "4.0", FullVersion = "4.0.0-custom-40")]
+[assembly: Raven.NewClient.RavenVersion(Build = "40", CommitHash = "a0c3e30", Version = "4.0", FullVersion = "4.0.0-custom-40")]


ppekrol · 2017-01-03T21:22:30Z

src/Raven.Server/Config/Categories/ReplicationConfiguration.cs

+        [DefaultValue(60 * 1000)]
+        [TimeUnit(TimeUnit.Milliseconds)]
+        [ConfigurationEntry("Raven/Replication/ReplicationTopologyDiscoveryTimeoutInMs")]
+        public TimeSetting ReplicationTopologyDiscoveryTimeout { get; set; }


Since the value is big, then maybe in Sec?

ppekrol · 2017-01-03T21:23:01Z

src/Raven.Server/Documents/Handlers/FullTopologyHandler.cs

+
+namespace Raven.Server.Documents.Handlers
+{
+    public class FullTopologyHandler : DatabaseRequestHandler


There is a TopologyHandler. Move this endpoint there?

ppekrol · 2017-01-03T21:23:22Z

src/Raven.Server/Documents/Handlers/FullTopologyHandler.cs

+{
+    public class FullTopologyHandler : DatabaseRequestHandler
+    {
+        [RavenAction("/databases/*/full-topology", "GET")]


/topology/graph? /topology/full?

hmmm... yeah this is better

ppekrol · 2017-01-03T21:23:53Z

src/Raven.Server/Documents/Handlers/FullTopologyHandler.cs

+            using (var writer = new BlittableJsonTextWriter(context, ResponseBodyStream()))
+            {
+                context.Write(writer, new NodeTopologyInfo().ToJson());
+                writer.Flush();


No need to flush

perhaps, but what is happening is more apparent with manual flush

ppekrol · 2017-01-03T21:23:59Z

src/Raven.Server/Documents/Handlers/FullTopologyHandler.cs

+                    using (var writer = new BlittableJsonTextWriter(context, ResponseBodyStream()))
+                    {
+                        context.Write(writer, topology.ToJson());
+                        writer.Flush();


No need to flush

ppekrol · 2017-01-03T21:24:51Z

src/Raven.Server/Documents/Replication/IncomingReplicationHandler.cs

            });

            writer.Flush();
+            LastHeartbeatTicks = DateTime.UtcNow.Ticks;


if you have access to DocumentDatabase then use DocumentDatabase.Time.UtcNow, if not then SystemTime.UtcNow

will do, but what is the reason for DocumentDatabase.Time.UtcNow?

We are running tests in parallel now, this is why we cannot override global SystemTime, so we introduced a 'local' one for each database

ppekrol · 2017-01-03T21:25:00Z

src/Raven.Server/Documents/Replication/OutgoingReplicationHandler.cs

@@ -398,6 +402,7 @@ internal void SendHeartbeat()
        private readonly AsyncManualResetEvent _neverSetEvent = new AsyncManualResetEvent();
        internal Tuple<ReplicationMessageReply.ReplyType,string> HandleServerResponse()
        {
+            LastHeartbeatTicks = DateTime.UtcNow.Ticks;


ppekrol · 2017-01-03T21:25:41Z

src/Raven.Studio/npm-debug.log

@@ -0,0 +1,49 @@
+0 info it worked if it ends with ok


ppekrol · 2017-01-03T21:27:06Z

test/FastTests/Server/Replication/ReplicationTopologyDiscoveryTests.cs

+                    new OperationCredentials(null, CredentialCache.DefaultCredentials), 
+                    new DocumentConvention())))
+            {
+                request.ExecuteRequest();


better use: var json = (RavenJObject)await request.ReadResponseJsonAsync()

ppekrol · 2017-01-03T21:32:50Z

src/Raven.Server/Documents/Handlers/FullTopologyHandler.cs

+                using (var clusterTopologyExplorer = new ReplicationClusterTopologyExplorer(
+                    Database,
+                    new Dictionary<string, List<string>>(),
+                    (long)Database.Configuration.Replication.ReplicationTopologyDiscoveryTimeout.AsTimeSpan.TotalMilliseconds,


you are passing long, which is a part of TimeSpan and inside ReplicationClusterTopologyExplorer you are building TimeSpan from that long again, just pass the TimeSpan?

good idea, don't see a reason why not.

ml054 · 2017-01-03T21:45:33Z

You can always rebase from time to time to avoid staying too far from main branch. :)

myarichuk added 2 commits January 3, 2017 19:57

RavenDB-5652 WIP

a48d934

Merge branch 'v4.0' of https://github.com/ravendb/ravendb into RavenD…

41c98b6

…B-5652-proper

ppekrol reviewed Jan 3, 2017

View reviewed changes

src/Raven.Studio/npm-debug.log

@@ -0,0 +1,49 @@

0 info it worked if it ends with ok

Copy link

Member

ppekrol Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

ppekrol reviewed Jan 3, 2017

View reviewed changes

ayende closed this Jan 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RavenDB-5652 WIP #1265

RavenDB-5652 WIP #1265

myarichuk commented Jan 3, 2017

ppekrol Jan 3, 2017

ayende Jan 4, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

myarichuk Jan 4, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

myarichuk Jan 4, 2017

ppekrol Jan 3, 2017

myarichuk Jan 4, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

myarichuk Jan 4, 2017

ppekrol Jan 4, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

ppekrol Jan 3, 2017

myarichuk Jan 4, 2017

ml054 commented Jan 3, 2017

RavenDB-5652 WIP #1265

RavenDB-5652 WIP #1265

Conversation

myarichuk commented Jan 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ml054 commented Jan 3, 2017