RavenDB-19163: Dispose CertificateHolder.Certificate on RavenServer dispose #14922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayende
approved these changes
Sep 13, 2022
ArieSLV
force-pushed
the
RavenDB-19163
branch
from
479ab5a
to
6bf0711
Compare
grisha-kotler
approved these changes
Sep 28, 2022
ArieSLV
force-pushed
the
RavenDB-19163
branch
3 times, most recently
from
7d21626
to
7ca9fe6
Compare
ppekrol
force-pushed
the
RavenDB-19163
branch
from
7ca9fe6
to
479fb9d
Compare
ppekrol
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RavenDB-19163/Dispose-CertificateHolderCertificate-on-RavenServer-dispose
Additional description
CertificateHolder.Certificateshould be disposed of onRavenServerdisposing of.Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Testing
Is there any existing behavior change of other features due to this change?
UI work