RavenDB-12319 spawn processes without handle inheritance to avoid getting HttpRequestException because of closed handle #8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting HttpRequestException because of closed handle
ppekrol
changed the title
ayende
reviewed
Nov 14, 2018
src/Sparrow/RavenProcess.cs
Outdated
|
|
||
| var process = new RavenProcess(); | ||
| if (process.StartWithCreateProcess(startInfo) == false) | ||
| throw new InvalidOperationException(); |
src/Sparrow/RavenProcess.cs
Outdated
|
|
||
| private unsafe bool StartWithCreateProcess(ProcessStartInfo startInfo) | ||
| { | ||
| var commandLine = BuildCommandLine(startInfo.FileName, startInfo.Arguments); |
There was a problem hiding this comment.
How much of this is Windows only?
|
@ayende I've compiled new System.Diagnostics.Process.dll (for Windows only) with InheritHandles option. |
|
@ayende I will merge this on Monday, after release |
ppekrol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP, I want CI to start testing this