Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall-back for wrongly formatted content-disposition headers #610

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fall-back for wrongly formatted content-disposition headers #610

merged 1 commit into from
Mar 31, 2023

Conversation

Aeon512
Copy link
Contributor

@Aeon512 Aeon512 commented Mar 25, 2023

Some servers provided wrongly formatted content-disposition headers, e.g. Artifactory writes as Content-Disposition

attachment; filename="setup.exe"; filename*=UTF-8''"setup.exe"

where the quotations (") within the filename* parameter yield a C# Format-Exception and cause a error message to be displayed. Since AutoUpdater.NET does not rely on the Content-Disposition Header but can fall-back to the filename from the download URL, this PR catches such errors and ignores such faulty Content-Disposition headers.

@ravibpatel ravibpatel merged commit 36b569c into ravibpatel:master Mar 31, 2023
@Aeon512
Copy link
Contributor Author

Aeon512 commented Mar 31, 2023

Thanks for accepting.
@ravibpatel Any plans for an 1.7.8 or 1.8.0 version? :-)
Seems like there is just the git tag missing....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants