Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall-back for wrongly formatted content-disposition headers #610

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fall-back for wrongly formatted content-disposition headers #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions AutoUpdater.NET/DownloadUpdateDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,19 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent
CompareChecksum(_tempFile, _args.CheckSum);
}

// try to parse the content disposition header if it exists
ContentDisposition contentDisposition = null;
if (!string.IsNullOrWhiteSpace(_webClient.ResponseHeaders?["Content-Disposition"]))
try
{
if (!string.IsNullOrWhiteSpace(_webClient.ResponseHeaders?["Content-Disposition"]))
{
contentDisposition = new ContentDisposition(_webClient.ResponseHeaders["Content-Disposition"]);
}
}
catch (FormatException)
{
contentDisposition = new ContentDisposition(_webClient.ResponseHeaders["Content-Disposition"]);
// ignore content disposition header if it is wrongly formated
contentDisposition = null;
}

var fileName = string.IsNullOrEmpty(contentDisposition?.FileName)
Expand Down