-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Commit To Provide Modular Base. #1
Conversation
|
||
|
||
@block | ||
def client(gtxClk, txData, txDataValid, txIFG_delay, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review the PEP8 naming conventions, CamelCase is typically reserved for class names.
Also, utilize interfaces in your blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay!
@cfelton done it. have a look. |
@cfelton, @jck, @josyb, @dargor0, @tompdillon
Reference - Xilinx UG144
http://www.xilinx.com/support/documentation/ip_documentation/gig_eth_mac_ug144.pdf