Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the following actions to use Node.js 20: ravsamhq/notify-slack-action@v2. #126

Open
alexatkoverse opened this issue Jan 31, 2024 · 6 comments
Assignees

Comments

@alexatkoverse
Copy link

as of jan 31, 2024
I am getting

"Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ravsamhq/notify-slack-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/."

when running your action v2 in GH
I did see that you closed recently ticket related to use node v16 and pushed update to use v20, but it seems to me it is only updated your own action yaml but not the node version that looks like still using node v16
"devDependencies": {
"@types/jest": "28.1.8",
"@types/node": "^18.0.0",

Copy link
Contributor

ravsam-bot bot commented Jan 31, 2024

Hello and welcome to RavSam 💜. Thanks for opening your first issue. I will assign one of our team members to take a look at the problem you have raised. Make sure to include as much information as possible to help our team diagnose the issue and solve it quickly.

If the problem is related to a security concern, then please delete this issue and send us an email at info@ravsam.in.

@markstos
Copy link

Use this version: "2.4.0".

There may be some confusion because a number of popular Github Actions use a version naming scheme like "@v2.3.4".

But this module doesn't include the leading "v". This caused a mistake for me too: I had updated several that included the "v". and then I got this module and I assumed it must be there too, but it wasn't.

It might be helpful if the leading "v" was added to future release tags to better align more of the Github Actions ecosystem.

@alexatkoverse
Copy link
Author

Thanks @markstos
when I tried as per above I am still getting similar warning "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ravsamhq/notify-slack-action@2.4.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/."

@fubha
Copy link

fubha commented Feb 1, 2024

@ravgeetdhillon seems it's still not resolved. I am using the latest version 2.4.0, but I am still getting a warning.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ravsamhq/notify-slack-action@2.4.0. 
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@somm-doe
Copy link

somm-doe commented Feb 5, 2024

Same here: Action still runs with Node.js 16 with either
ravsamhq/notify-slack-action@v2.4.0
or
ravsamhq/notify-slack-action@2.4.0

markstos added a commit to markstos/notify-slack-action that referenced this issue Feb 5, 2024
@ravgeetdhillon
Copy link
Member

This has been fixed in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants