Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better commands name #11

Closed
lnc3l0t opened this issue May 15, 2023 · 3 comments · Fixed by #13
Closed

Better commands name #11

lnc3l0t opened this issue May 15, 2023 · 3 comments · Fixed by #13

Comments

@lnc3l0t
Copy link
Contributor

lnc3l0t commented May 15, 2023

I think prefixing the plugin "name" is better than suffixing it.

Let's have the commands become:

  • CreateGist -> GistCreate
  • CreateGistFromFile -> GistFromFile
  • ListGists -> GistsList

I think the commands may be more easily remembered
@rawnly
Copy link
Owner

rawnly commented May 15, 2023

LGTM I'll do a pr by the end of the day, I think i'll keep old names for this release and remove them in the next one. In order to let people easily migrate. (maybe with a warning)

@lnc3l0t
Copy link
Contributor Author

lnc3l0t commented May 15, 2023

Nice! If you want to focus on something else I'm doing a PR myself, but I'm focusing on the other issue #10 first

@rawnly
Copy link
Owner

rawnly commented May 15, 2023

Uh! Thank you!

lnc3l0t added a commit to lnc3l0t/gist.nvim that referenced this issue May 15, 2023
@lnc3l0t
improv: changed names to have Gist at the beginning (fixes rawnly#11)
af34ec0 
:%s/CreateGist/GistCreate/g
:%s/ListGists/GistsList/g

Changed all names!
@rawnly rawnly linked a pull request May 16, 2023 that will close this issue
Better names #13
Merged
rawnly pushed a commit that referenced this issue May 16, 2023
@lnc3l0t @rawnly
improv: changed names to have Gist at the beginning (fixes #11)
3241c1f 
:%s/CreateGist/GistCreate/g
:%s/ListGists/GistsList/g

Changed all names!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better names lnc3l0t/gist.nvim
2 participants
@rawnly @lnc3l0t