Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe repository updates do not propagate during M-x straight-pull-all #323

Open
raxod502 opened this issue Oct 31, 2018 · 2 comments
Open

Comments

@raxod502
Copy link
Member

Let us consider the following situation:

  1. User runs M-x straight-pull-all
  2. MELPA is updated, changing the recipe for package X from A to B
  3. Package X is updated

However, in step 3 the recipe A is used rather than the recipe B. This is confusing and violates the principle of least surprise. We should change something.

@progfolio
Copy link
Contributor

#576 can be used programmatically to pull recipe repositories first.

@raxod502
Copy link
Member Author

That is an improvement, but unfortunately it does not fully solve the problem. The reason is that, while pulling a recipe repository updates the recipes on disk, we actually need to re-run recipe resolution to propagate the changes into memory. It's also not just a matter of doing special-case lookups after pulling a recipe repository, because we need to handle inheritance correctly. I think the most appropriate way to solve the problem, aside from forcing a reload of the init-file (which seems rather bad), is to record a list of the exact sequence of calls to straight-use-package during init. Then we can simply replay them whenever we want, without forcing a reload of the init-file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants