-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support toProvider, toInstance() bind in multibindings #264
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #264 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 341 357 +16
===========================================
Files 46 49 +3
Lines 888 937 +49
===========================================
+ Hits 888 937 +49
Continue to review full report at Codecov.
|
7f0a434
to
37b665b
Compare
Throw SetNotFound when Map is injected but not Set attribute/annotation is not found
6ba88fb
to
3219dcf
Compare
composer.json
Outdated
"ray/aop": "^2.10" | ||
}, | ||
"require-dev": { | ||
"ext-pdo": "*", | ||
"phpunit/phpunit": "^9.5.10", | ||
"phpunit/phpunit": "^8.5.23", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8系はPHP 8 のカバレッジが取れないみたいです。
https://github.com/ray-di/Ray.Di/runs/5456812078?check_suite_focus=true
Error: This version of PHPUnit does not support code coverage on PHP 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうでしたね。9にするとPHP 7.2がサポートされずでどうしましょうかね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
というか、7.2をサポートできてないのにcomposer.jsonの表記が間違ってます><
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaokiTsuchiya PHP 7.2をサポートしました。Auraと同じくRay.*はPHP 7.2+、BEARはポリシー通り7.4+にします。
acf4d05
to
9fd3ac4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@NaokiTsuchiya Thanks for the review! (should be hard) |
マルチバインディングでのAPI変更