Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generics syntax to ProviderInterface #269

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Conversation

koriym
Copy link
Member

@koriym koriym commented Mar 7, 2022

#267
After #264

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #269 (c48c5bd) into 2.x (acdcc2e) will decrease coverage by 18.70%.
The diff coverage is n/a.

❗ Current head c48c5bd differs from pull request most recent head 277b6b1. Consider uploading reports for the commit 277b6b1 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##                 2.x     #269       +/-   ##
==============================================
- Coverage     100.00%   81.29%   -18.71%     
  Complexity       351      351               
==============================================
  Files             47       47               
  Lines            911      909        -2     
==============================================
- Hits             911      739      -172     
- Misses             0      170      +170     
Impacted Files Coverage Δ
src/di/Di/Set.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/MultiBinder.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/MultiBinding/Map.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/MultiBinding/LazyTo.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/ProviderSetProvider.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/AssistedInjectModule.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/MultiBinding/MapProvider.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/AssistedInjectInterceptor.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/MultiBinding/LazyInstance.php 0.00% <0.00%> (-100.00%) ⬇️
src/di/MultiBinding/LazyProvider.php 0.00% <0.00%> (-100.00%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdcc2e...277b6b1. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Mar 9, 2022
@koriym koriym merged commit 2f073cb into ray-di:2.x Mar 9, 2022
@koriym koriym deleted the provider branch March 9, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant