Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clientset for RayCluster objects #29

Closed
Jeffwan opened this issue Sep 12, 2021 · 5 comments
Closed

Support clientset for RayCluster objects #29

Jeffwan opened this issue Sep 12, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 12, 2021

We have some backend services written in Golang wants to interact with RayCluster Kubernetes objects and it needs to use typed clients.

Kubebuilder itself doesn't generate clients for objects. It would be great to leverage code-gen to generate clientset for external system to interact with

@Jeffwan Jeffwan added enhancement New feature or request good first issue Good for newcomers labels Sep 12, 2021
@chenk008
Copy link
Contributor

chenk008 commented Sep 14, 2021

It's useful to integrate with Ray devops platform.

@harryge00
Copy link
Contributor

@chenk008 @Jeffwan I can take this if nobody else is going to implement it

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 17, 2021

@harryge00 Feel free to pick it up. The tricky part is kubebuilder structure is not friendly to reuse code-gen. I think we may need to adjust api structures like

  • api
    • raycluster
      • v1alpha1

If you have other ways without reorganize the folder, that would be great

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 3, 2021

@harryge00 The last PR is to generate clientset, can you help on that as well?

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 4, 2021

This issue can be closed. Thanks for the contribution. @harryge00

@Jeffwan Jeffwan closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants