Add codegen scripts and make required api changes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Nov 2, 2021
|
@harryge00 Do you mind giving me the collaborator permission to your repo and I can co-author with you in this PR? Which one do you prefer? |
|
@Jeffwan I've invited you to my repo. |
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
1. Add update-codegen.sh and verify-codegen.sh 2. Add required changes to register.go and doc.go and //+genclient tag in raycluster_types.go Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan
force-pushed
the
codegen-scripts
branch
from
c28c031
to
c2d28e5
Compare
Jeffwan
changed the title
|
@harryge00 I update the PR and manually generate clients but have not checked in. Please have a review |
4 tasks
harryge00
commented
Nov 3, 2021
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Update go modules to include code-generator * Add scripts to generate clients * Clean up code-generator dependency Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Update codegen scripts and make required api changes 1. Add update-codegen.sh and verify-codegen.sh 2. Add required changes to register.go and doc.go and //+genclient tag in raycluster_types.go Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> Co-authored-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To support clientset for RayCluster objects, we may use
code-gento generate clientset. With PR, you can runhack/update-codegen.shto generate clientset. The generated code will be atpkg/client/clientsetRelated issue number
#29
Checks