Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples yaml #102

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Update samples yaml #102

merged 2 commits into from
Nov 21, 2021

Conversation

ryantd
Copy link
Contributor

@ryantd ryantd commented Nov 20, 2021

Why are these changes needed?

  1. Update configmap
    1. Rename the script to avoid a "ray has no attribute init" issue [1]
    2. Fix services.get_node_ip_address
    3. Change ray_nodes dir to avoid a Permission error
  2. Update yaml
    1. Bump rayVersion to 1.8.0
    2. Bump ray image version to 1.8.0
    3. Change command: sleep infinity
    4. Add a comment on init-myservice's command

[1]:

trying to connect to Ray!
Traceback (most recent call last):
  File "/opt/code.py", line 1, in <module>
    import ray
  File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/__init__.py", line 91, in <module>
    import ray._raylet  # noqa: E402
  File "python/ray/_raylet.pyx", line 118, in init ray._raylet
  File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/_private/runtime_env/validation.py", line 11, in <module>
    from ray._private.runtime_env.plugin import RuntimeEnvPlugin
  File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/_private/runtime_env/plugin.py", line 3, in <module>
    from ray.util.annotations import DeveloperAPI
  File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/util/__init__.py", line 14, in <module>
    from ray.util import rpdb as pdb
  File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/util/rpdb.py", line 16, in <module>
    from pdb import Pdb
  File "/home/ray/anaconda3/lib/python3.7/pdb.py", line 76, in <module>
    import code
  File "/opt/..2021_11_19_09_25_09.256271217/code.py", line 5, in <module>
    ray.init(address="auto", _redis_password=redis_pass)
AttributeError: module 'ray' has no attribute 'init'

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan
Copy link
Collaborator

Jeffwan commented Nov 21, 2021

Thanks for the contribution, the change looks good to me beside above minor comment

@ryantd
Copy link
Contributor Author

ryantd commented Nov 21, 2021

@Jeffwan PTAL

@ryantd ryantd requested a review from Jeffwan November 21, 2021 09:13
@Jeffwan Jeffwan merged commit 55ee446 into ray-project:master Nov 21, 2021
@ryantd ryantd deleted the update-samples-yaml branch November 21, 2021 13:25
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* Update samples yaml

* Remove configmap volumn part to keep the mini one clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants