-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to enable/disable worker init container injection #1069
Add a flag to enable/disable worker init container injection #1069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this env variable in KubeRay operator Helm chart with the default value "true" and warning comments.
@ByronHsu Here is a conflict. Would you mind rebasing with the master branch? |
1c5f5de
to
4b100d3
Compare
Would you mind fixing the lint error and adding this env variable in KubeRay operator Helm chart with the default value "true" and warning comments? Thanks! |
e2e test done
|
Signed-off-by: byhsu <byhsu@linkedin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for this contribution!
I also tested it manually.
# path: helm-chart/kuberay-operator
# Step 1: Update values.yaml
- name: ENABLE_INIT_CONTAINER_INJECTION
value: "false"
# Step 2: Install the KubeRay operator with the new image
helm install kuberay-operator . --set image.repository=controller,image.tag=latest
# Step 3: Install a RayCluster with a init container "busybox"
helm install raycluster kuberay/ray-cluster --version 0.5.0
# Step 4: The worker Pod will only have 1 init container.
# path: helm-chart/kuberay-operator
# Step 1: Update values.yaml
- name: ENABLE_INIT_CONTAINER_INJECTION
value: "true"
# Step 2: Install the KubeRay operator with the new image
helm install kuberay-operator . --set image.repository=controller,image.tag=latest
# Step 3: Install a RayCluster with a init container "busybox"
helm install raycluster kuberay/ray-cluster --version 0.5.0
# Step 4: The worker Pod will have 2 init containers.
…ject#1069) Add a flag to enable/disable worker init container injection
Why are these changes needed?
Currently, the init container is always injected into the worker pod with a specific command. However, in our case,
ray
does not exist in the$PATH
so it failed. We want to have a way to disable the injection from kuberay and customize our own injection. This PR adds an envENABLE_INIT_CONTAINER_INJECTION
to switch the init container injection.Checks