-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm #109
Add helm #109
Conversation
c0e0ba3
to
c18c2a8
Compare
replicaCount: 1 | ||
|
||
image: | ||
repository: docker.io/library/controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check image from current master for the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run "make docker-build" command, and it shows me "naming to docker.io/library/controller:latest". Is this the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got you. We normally use IMG=xxx make docker-build
to override the IMG. I think we have not updated Makefile and that's why you get docker.io/library/controller:latest
I would suggest to rename |
Thanks for the contribution. Let's have a test before we merge the code. @zhuangzhuang131419 At the same time, could you please also add quick start for users? You can change root level README.md or ray-operator/README.md |
I add the README link of helm into the root README. I test the helm manually, and it works as I expected. |
object-manager-port: '12345' | ||
node-manager-port: '12346' | ||
object-store-memory: '100000000' | ||
redis-password: 'LetMeInRay' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default to not having a password?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refer to the file in config/samples/
. redis-password is necessary. Otherwise, the pod will report a redis.exceptions.ResponseError: WRONGPASS invalid username-password pair
.
* Add helm chart * fix * add README Co-authored-by: zhuang <zhengchicheng.zcc@alibaba-inc.com>
Why are these changes needed?
A helm chart is a collection of files that describe a related set of Kubernetes resources. It can help users to deploy ray-operator and ray clusters conveniently.
We use kustomize to deploy into different Kubernetes clusters and deliver helm charts to other users who want to try Ray on their Kubernetes clusters.
Users can use
helm install
to deploy operator and cluster, andhelm delete
to delete it. The more specific guidance is in README file. Helm provides flexibility on cluster configurations, user can create their own clusters by editing the values.yaml file.Related issue number
#41
Checks