Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm #109

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Add helm #109

merged 3 commits into from
Dec 21, 2021

Conversation

zhuangzhuang131419
Copy link
Contributor

Why are these changes needed?

A helm chart is a collection of files that describe a related set of Kubernetes resources. It can help users to deploy ray-operator and ray clusters conveniently.

We use kustomize to deploy into different Kubernetes clusters and deliver helm charts to other users who want to try Ray on their Kubernetes clusters.

Users can use helm install to deploy operator and cluster, and helm delete to delete it. The more specific guidance is in README file. Helm provides flexibility on cluster configurations, user can create their own clusters by editing the values.yaml file.

Related issue number

#41

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

helm-chart/ray-cluster-helm/README.md Outdated Show resolved Hide resolved
replicaCount: 1

image:
repository: docker.io/library/controller
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check image from current master for the default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run "make docker-build" command, and it shows me "naming to docker.io/library/controller:latest". Is this the default value?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you. We normally use IMG=xxx make docker-build to override the IMG. I think we have not updated Makefile and that's why you get docker.io/library/controller:latest

@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 6, 2021

I would suggest to rename ray-cluster-helm to ray-cluster, ray-operator-helm to kuberay-operator.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 10, 2021

Thanks for the contribution. Let's have a test before we merge the code. @zhuangzhuang131419 At the same time, could you please also add quick start for users? You can change root level README.md or ray-operator/README.md

@zhuangzhuang131419
Copy link
Contributor Author

I add the README link of helm into the root README. I test the helm manually, and it works as I expected.

object-manager-port: '12345'
node-manager-port: '12346'
object-store-memory: '100000000'
redis-password: 'LetMeInRay'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default to not having a password?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refer to the file in config/samples/. redis-password is necessary. Otherwise, the pod will report a redis.exceptions.ResponseError: WRONGPASS invalid username-password pair.

@Jeffwan Jeffwan merged commit 1a8aaad into ray-project:master Dec 21, 2021
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* Add helm chart

* fix

* add README

Co-authored-by: zhuang <zhengchicheng.zcc@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants