-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make replicas optional for the worker spec #1154
Conversation
fa39217
to
bc9220c
Compare
I will review it today or tomorrow. Thanks! |
Related issue: #265 |
ba0fd0c
to
d7158b9
Compare
@kevin85421 I've got an error following the steps in the docs. How can I fix that? # Python 3.10.12
pip install -r tests/config/requirements.txt
cd ray-operator
make build
go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-tools/cmd/controller-gen@v0.6.0
...
/Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
bash: /Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen: No such file or directory
make: *** [generate] Error 127 make manifests
...
/Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen "crd:maxDescLen=100,trivialVersions=true,preserveUnknownFields=false,generateEmbeddedObjectMeta=true,allowDangerousTypes=true" rbac:roleName=kuberay-operator webhook paths="./..." output:crd:artifacts:config=config/crd/bases
bash: /Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen: No such file or directory
make: *** [manifests] Error 127
|
Hi @manifest, You may need to use go1.17.6. See https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#use-go-v117. |
The replicas field must not be set when autoscaler is used because: - Autoscaler updates the field. - When GitOps systems such as FluxCD or ArgoCD are used, they keep reverting changes made by the autoscaler on every reconciliation.
d7158b9
to
9a628c5
Compare
I was now able to run consistency check steps. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please test the autoscaling YAML files? It may throw an error for a nil pointer dereference. You should revisit all references to Replicas
.
Why are these changes needed?
The replicas field must not be set when autoscaler is used because:
Related issue number
Closes #1120
Checks