Make replicas optional for the worker spec #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
force-pushed
the
optional-worker-replicas
branch
from
fa39217
to
bc9220c
Compare
|
I will review it today or tomorrow. Thanks! |
|
Related issue: #265 |
manifest
force-pushed
the
optional-worker-replicas
branch
2 times, most recently
from
ba0fd0c
to
d7158b9
Compare
|
@kevin85421 I've got an error following the steps in the docs. How can I fix that? # Python 3.10.12
pip install -r tests/config/requirements.txt
cd ray-operator
make build
go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-tools/cmd/controller-gen@v0.6.0
...
/Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
bash: /Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen: No such file or directory
make: *** [generate] Error 127make manifests
...
/Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen "crd:maxDescLen=100,trivialVersions=true,preserveUnknownFields=false,generateEmbeddedObjectMeta=true,allowDangerousTypes=true" rbac:roleName=kuberay-operator webhook paths="./..." output:crd:artifacts:config=config/crd/bases
bash: /Users/manifest/development/github/kuberay/ray-operator/bin/controller-gen: No such file or directory
make: *** [manifests] Error 127
|
|
Hi @manifest, You may need to use go1.17.6. See https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#use-go-v117. |
The replicas field must not be set when autoscaler is used because: - Autoscaler updates the field. - When GitOps systems such as FluxCD or ArgoCD are used, they keep reverting changes made by the autoscaler on every reconciliation.
manifest
force-pushed
the
optional-worker-replicas
branch
from
d7158b9
to
9a628c5
Compare
|
I was now able to run consistency check steps. Thank you. |
kevin85421
reviewed
Jun 20, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The replicas field must not be set when autoscaler is used because:
Related issue number
Closes #1120
Checks