Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobileNet example #1175

Merged
merged 10 commits into from
Jun 21, 2023
Merged

MobileNet example #1175

merged 10 commits into from
Jun 21, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jun 20, 2023

Why are these changes needed?

Related issue number

Closes #1170

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
Screen Shot 2023-06-20 at 4 30 09 PM

Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! I left some comments.

docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
docs/guidance/mobilenet-rayservice.md Outdated Show resolved Hide resolved
ray-operator/config/samples/ray-service.mobilenet.yaml Outdated Show resolved Hide resolved
ray-operator/config/samples/ray-service.mobilenet.yaml Outdated Show resolved Hide resolved
ray-operator/config/samples/ray-service.mobilenet.yaml Outdated Show resolved Hide resolved
kevin85421 and others added 7 commits June 21, 2023 00:58
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
kevin85421 and others added 2 commits June 21, 2023 11:43
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kevin85421 kevin85421 merged commit 1d98fec into ray-project:master Jun 21, 2023
19 of 20 checks passed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] poc with mobilenet: service isn't created
5 participants