Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove Dashboard Agent service #1207

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jun 29, 2023

Why are these changes needed?

Without #1173, the Kubernetes service for the dashboard agent uses a round-robin algorithm to evenly distribute traffic among the available Pods, including the head Pod and worker Pods. This may cause stability issues. Hence, #1173 decides to only send the requests to the head service's 52365 (dashboard agent port). The dashboard agent service is no longer used after #1173, so this PR aims to remove the service.

pod.go

  1. Merge setAgentListPortStartParams into setMissingRayStartParams: The function setAgentListPortStartParams will always be called after setMissingRayStartParams and both have very similar functionalities. Hence, there is no reason to keep them as two separate functions.

  2. Remove RayClusterDashboardServiceLabelKey: utils.GenerateDashboardAgentLabel(rayClusterName) from Pod labels. The label is for the dashboard agent service's selector.

Related issue number

#1173

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
RAY_IMAGE=rayproject/ray:2.5.0 OPERATOR_IMAGE=controller:latest pytest -vs tests/test_sample_rayservice_yamls.py --log-cli-level=INFO
Screen Shot 2023-06-29 at 8 23 10 AM

@kevin85421 kevin85421 changed the title WIP [Refactor] Remove Dashboard Agent service Jun 29, 2023
@kevin85421 kevin85421 marked this pull request as ready for review June 29, 2023 15:24
@kevin85421 kevin85421 merged commit 3d533b4 into ray-project:master Jun 29, 2023
20 checks passed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants