[Refactor] Remove Dashboard Agent service #1207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Without #1173, the Kubernetes service for the dashboard agent uses a round-robin algorithm to evenly distribute traffic among the available Pods, including the head Pod and worker Pods. This may cause stability issues. Hence, #1173 decides to only send the requests to the head service's 52365 (dashboard agent port). The dashboard agent service is no longer used after #1173, so this PR aims to remove the service.
pod.go
Merge
setAgentListPortStartParams
intosetMissingRayStartParams
: The functionsetAgentListPortStartParams
will always be called aftersetMissingRayStartParams
and both have very similar functionalities. Hence, there is no reason to keep them as two separate functions.Remove
RayClusterDashboardServiceLabelKey: utils.GenerateDashboardAgentLabel(rayClusterName)
from Pod labels. The label is for the dashboard agent service's selector.Related issue number
#1173
Checks