[Refactor] Rename EnableAgentService to EnableServeService #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @blublinsky Would you mind taking a look at the changes in the API Server? Thanks! |
architkulkarni
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#1207 removed the K8s service for the dashboard agent, but there are still some variables with "AgentService" in their names. This may cause misleading, so this PR changes
EnableAgentServicetoEnableServeService. In fact, the K8s service introduced by #1672 is designed for serving purposes. It is used to expose HTTP Proxy actors on each Ray node.Related issue number
Follow up for #1672 (comment)
Checks