Remove unnecessary kustomize in make helm #1370
Conversation
|
@kevin85421 This is the PR for 1368. I don't seem to have access to assignees section to add you as the reviewer. Thanks! |
|
Could you remove kustomize from helm in the Makefile as I mentioned in #1368 (comment)? Additionally, would you test all the kustomize-related targets listed in the Makefile? In addition, are there any breaking changes between |
|
@kevin85421 Apologies for missing the helm part. I have updated the code changes. I will comment on this PR once I am done with the testing and the investigation. Thanks for the review. |
ray-operator/Makefile
Outdated
| @@ -114,7 +114,7 @@ controller-gen: ## Download controller-gen locally if necessary. | |||
|
|
|||
| KUSTOMIZE = $(shell pwd)/bin/kustomize | |||
| kustomize: ## Download kustomize locally if necessary. | |||
| test -s $(KUSTOMIZE) || GOBIN=$(KUSTOMIZE)/.. go install sigs.k8s.io/kustomize/kustomize/v3@v3.10.0 | |||
| test -s $(KUSTOMIZE) || GOBIN=$(KUSTOMIZE)/.. go install sigs.k8s.io/kustomize/kustomize/v5@v5.1.1 | |||
There was a problem hiding this comment.
Do you want to just use latest?
|
@kevin85421 I tried the targets using Kustomize and they are building fine on my machine. Also, the kustomize version being used in apiserver is 3.8.7, should we upgrade that as well? |
|
Closing this as the issue was fixed as part of e7fbf7d |
^ cc @blublinsky |
shubhscoder
force-pushed
the
upgrade_kustomize
branch
from
1714232
to
d1b9772
Compare
If needed, I can create a seperate PR for that. Since this one was open, I removed the unnecessary kustomize in make helm |
shubhscoder
changed the title
|
Yes, I think we should upgrade kustomize throughout the project to the same version |
Thanks! I will create an issue and raise a CR to make kustomize version consistent across the project. |
Remove kustomize from helm, as it is not required
Why are these changes needed?
We first make kustomize as part of make helm (and hence make sync). But this is not required. This was realized while running make sync. This code change simply removes kustomize from make helm.
Related issue number
Closes #1368
Checks