Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use image of Ray head container as the default Ray Autoscaler container #1401

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Sep 6, 2023

Why are these changes needed?

Before the introduction of this PR, KubeRay used to determine the Ray Autoscaler sidecar container's image based on the rayVersion parameter.

  • Case 1: If this version was older than Ray 2.0.0, KubeRay defaulted to using Ray 2.0.0 for the sidecar container image.
  • Case 2: In other cases, it used the same image as the Ray head container. For more information, please refer to autoscalerSupportIsStable and getAutoscalerImage.

Case 1 is not necessary at this moment because KubeRay does not guarantee the support of a version older than Ray 2.0.0. In addition, there is no compatibility test for the version mismatch between Ray Autoscaler and Ray.

I also removed the description of the rayVersion behavior in ray-project/ray#39345.
Screen Shot 2023-09-06 at 5 21 48 PM

Related issue number

Checks

@kevin85421 kevin85421 changed the title [Feature] Deprecate RayVersion [Feature] Use Ray head container as the default Ray Autoscaler container Sep 7, 2023
@kevin85421 kevin85421 changed the title [Feature] Use Ray head container as the default Ray Autoscaler container [Feature] Use image of Ray head container as the default Ray Autoscaler container Sep 7, 2023
@kevin85421 kevin85421 marked this pull request as ready for review September 7, 2023 00:21
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but doesn't KubeRay guarantee compatibility with the last Ray 1.x version?

@kevin85421
Copy link
Member Author

The code looks good, but doesn't KubeRay guarantee compatibility with the last Ray 1.x version?

Yes, KubeRay offers compatibility with Ray 1.13.0 for certain features. However, the compatibility mentioned above involves using Ray 1.x for the Ray container and Ray 2.0.0 for the Ray Autoscaler sidecar container. If I recall correctly, no one has yet tested or tried this combination.

@architkulkarni
Copy link
Contributor

Makes sense, thanks!

@kevin85421 kevin85421 merged commit f4412f6 into ray-project:master Sep 7, 2023
21 checks passed
z103cb pushed a commit to z103cb/kuberay that referenced this pull request Sep 11, 2023
…er container (ray-project#1401)

Use image of Ray head container as the default Ray Autoscaler container
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…er container (ray-project#1401)

Use image of Ray head container as the default Ray Autoscaler container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants