-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the apiserver swagger-ui #1410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tedhtchang, @kevin85421 and @anishasthana I have closed #1387 in favour of this PR. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I verified the swagger UI working. Steps:
# run apiserver locally
make run
# Check swagger ui http://localhost:8888/swagger-ui/ in the browser
More ways to test: deploy a RayCluster using the swagger ui #1387 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed this PR, but I approved it because it only changes KubeRay API Server and it receives two approvals from IBM / RedHat folks.
The RayService e2e tests are known to be flaky. It is not related with this PR. Merge this PR. |
Updates to the apiserver swagger-ui
Fixes #1343
Why are these changes needed?
Current implementation of the Kuberay API server present the vanilla pet store implementation in the
/swagger-ui/
endpoint. This PR fixes this issues.The changes are:
Related issue number
Closes #1343
Checks