Updates to the apiserver swagger-ui #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
z103cb
commented
Sep 11, 2023
There was a problem hiding this comment.
@tedhtchang, @kevin85421 and @anishasthana I have closed #1387 in favour of this PR. Please take a look.
tedhtchang
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
LGTM. I verified the swagger UI working. Steps:
# run apiserver locally
make run
# Check swagger ui http://localhost:8888/swagger-ui/ in the browserMore ways to test: deploy a RayCluster using the swagger ui #1387 (review)
kevin85421
approved these changes
Sep 11, 2023
|
The RayService e2e tests are known to be flaky. It is not related with this PR. Merge this PR. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Updates to the apiserver swagger-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1343
Why are these changes needed?
Current implementation of the Kuberay API server present the vanilla pet store implementation in the
/swagger-ui/endpoint. This PR fixes this issues.The changes are:
Related issue number
Closes #1343
Checks