Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use raycluster app's name as podgroup name key word #1446

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

lowang-bh
Copy link
Contributor

@lowang-bh lowang-bh commented Sep 24, 2023

Why are these changes needed?

ClusterName has been removed in higher K8S version.
In order to be compatible with feature upgrade.

Related issue number

Closes #1445

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@lowang-bh
Copy link
Contributor Author

/assign @Yicheng-Lu-llll

Signed-off-by: lowang-bh <lhui_wang@163.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@kevin85421 kevin85421 merged commit 243592f into ray-project:master Sep 25, 2023
21 of 22 checks passed
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
use raycluster app's name as podgroup name key word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] volcano_scheduler_test.go use a field which will be removed in higher K8S version
2 participants