Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRD][1/n] Create v1 CRDs #1481

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[CRD][1/n] Create v1 CRDs #1481

merged 2 commits into from
Oct 11, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 11, 2023 •
edited

Why are these changes needed?

This PR is the first step of #1209 (comment). I followed the kubebuilder doc except the webhook part to bump the CRD version.

# Step 1
kubebuilder create api --group ray --version v1 --kind RayCluster
kubebuilder create api --group ray --version v1 --kind RayJob
kubebuilder create api --group ray --version v1 --kind RayService

# Step 2: Create `*_types.go` in `ray-operator/apis/ray/v1`

# Step 3: Set v1alpha1 as the storage version

# Step 4: Create new CRDs
make manifests

Related issue number

#1209

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review October 11, 2023 19:15
@kevin85421
Copy link
Member Author

cc @hongchaodeng @gvspraveen would you mind taking a look? This is the first PR of CRD version bumping.

hongchaodeng
hongchaodeng approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hongchaodeng
Copy link
Member

Low risk. Merging now.

@hongchaodeng hongchaodeng merged commit b7bc7ae into ray-project:master Oct 11, 2023
23 checks passed
This was referenced Oct 12, 2023
Merged
Closed
Closed
Merged
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
@kevin85421
[CRD][1/n] Create v1 CRDs (ray-project#1481)
fd42042
kevin85421 added a commit that referenced this pull request Oct 17, 2023
@kevin85421
[CRD][1/n] Create v1 CRDs (#1481) (#1525)
c24bf48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongchaodeng hongchaodeng hongchaodeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevin85421 @hongchaodeng