Simplify k8s client creation #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold This change will result to compilation failed. We need to bump |
chenk008
force-pushed
the
simplify_k8s_client_creation
branch
from
dd458a2
to
dc6dbd9
Compare
Jeffwan
approved these changes
Mar 22, 2022
| if err != nil { | ||
| return nil, errors.Wrap(err, "Failed to initialize kubernetes client.") | ||
| glog.Fatalf("Failed to create TokenReview client. Error: %v", err) |
There was a problem hiding this comment.
The precedence changes a little bit. config.GetConfig() checks --kubeconfig first and then in-cluster config. I can not remember why I choose to check in-cluster first and then external. The change should work for us.
Config precedence after the change. https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client/config#GetConfig
* --kubeconfig flag pointing at a file
* KUBECONFIG environment variable pointing at a file
* In-cluster config if running in cluster
* $HOME/.kube/config if exists.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Co-authored-by: wuhua.ck <wuhua.ck@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently when we create kubernetes client, it will check if it is running in K8s' pod. And this logic is implemented in
sigs.k8s.io/controller-runtime/pkg/client/config. Additional thecontroller-runtimesupport enviroment KUBECONFIG .The official tool can help to simplify the code.
Related issue number
Checks