bump controller-runtime to 0.11.1 and Kubernetes to v1.23 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenk008
force-pushed
the
bump_controller_runtime
branch
from
ddaa609
to
ba0a25f
Compare
|
Let's hold this change until we release v0.2.0. We pin stable version to 1.19 and that should work for cluster between 1.19-1.22 |
|
We release v0.2.0 and this can be unblocked |
Jeffwan
changed the title
|
I update the title to include kubernetes which makes us easier to track changes later. |
|
The changes look good to me. Let's bump the version. |
Jeffwan
approved these changes
Mar 14, 2022
chenk008
added a commit
that referenced
this pull request
Mar 22, 2022
* bump controller-runtime to 0.11.1 * fix Co-authored-by: wuhua.ck <wuhua.ck@alibaba-inc.com>
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…t#180) * bump controller-runtime to 0.11.1 * fix Co-authored-by: wuhua.ck <wuhua.ck@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In kubeRay, we use controller-runtime to create K8s client, manage reconciler controllers. Currently we use
0.7.2, it is incompatible withlogr v1.0.0. Bump thecontroller-runtimeto 0.11.1, it will be compatible with logr and help kubeRay to follow the version upgrade of the K8s community.Related issue number
Checks