Support envFrom in rayclusters deployed with Helm #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
approved these changes
Mar 11, 2022
|
Thanks for the contribution! |
chenk008
pushed a commit
that referenced
this pull request
Mar 22, 2022
Co-authored-by: Eugene Brodsky <eugene@proteinqure.com>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Co-authored-by: Eugene Brodsky <eugene@proteinqure.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It is often useful to populate the container environment with values specified as Kubernetes secrets or configmaps, using the
envFromkey of the pod spec. For example, we use this technique to provide database credentials to our pods.This PR implements such functionality for Ray clusters deployed with Helm.
Checks