run compatibility in parallel using multiple workflows #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonwang371
force-pushed
the
wilson/parallel-workflow
branch
10 times, most recently
from
a6dc8b0
to
ee83eef
Compare
wilsonwang371
force-pushed
the
wilson/parallel-workflow
branch
from
ee83eef
to
51a30e0
Compare
|
@Jeffwan please take a look at this patch. It is ready for review now. |
Jeffwan
reviewed
Mar 29, 2022
| - name: Build Docker Image - Apiserver | ||
| run: docker build -t kuberay/apiserver:${{ steps.vars.outputs.sha_short }} -f apiserver/Dockerfile . | ||
| - name: Upload Artifact Operator | ||
| uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
I am new to this plugin, How does upload-artifact work?
There was a problem hiding this comment.
It will upload a file that we can use later in other jobs. I want to reuse the images built here in other following jobs.
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: operator_img | ||
| path: /tmp/operator.tar |
There was a problem hiding this comment.
What's the lifecycle of /tmp/operator.tar? Do we need to rename it with git hash etc?
There was a problem hiding this comment.
no need, later when we load it again, it will have the same tag when we save it.
There was a problem hiding this comment.
it should be only availlable on ths same workflow.
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Run compatibility tests in parallel to save time
Related issue number
#159
Checks