-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run compatibility in parallel using multiple workflows #215
run compatibility in parallel using multiple workflows #215
Conversation
a6dc8b0
to
ee83eef
Compare
ee83eef
to
51a30e0
Compare
@Jeffwan please take a look at this patch. It is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor comments. @wilsonwang371
- name: Build Docker Image - Apiserver | ||
run: docker build -t kuberay/apiserver:${{ steps.vars.outputs.sha_short }} -f apiserver/Dockerfile . | ||
- name: Upload Artifact Operator | ||
uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am new to this plugin, How does upload-artifact work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will upload a file that we can use later in other jobs. I want to reuse the images built here in other following jobs.
uses: actions/upload-artifact@v2 | ||
with: | ||
name: operator_img | ||
path: /tmp/operator.tar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the lifecycle of /tmp/operator.tar
? Do we need to rename it with git hash etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need, later when we load it again, it will have the same tag when we save it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be only availlable on ths same workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Make sense
Why are these changes needed?
Run compatibility tests in parallel to save time
Related issue number
#159
Checks