Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicated port config and manager.yaml missing config #250

Merged
merged 1 commit into from
May 11, 2022
Merged

fix duplicated port config and manager.yaml missing config #250

merged 1 commit into from
May 11, 2022

Conversation

wilsonwang371
Copy link
Collaborator

Why are these changes needed?

This patch fixed tow bugs:

  1. add missing port declaration in manager.yaml file
  2. avoid adding the same port again if it already exists in existing pod template.

Related issue number

#249

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@wilsonwang371
Copy link
Collaborator Author

cc @Jeffwan @scarlet25151

@scarlet25151
Copy link
Collaborator

LGTM.

@Jeffwan Jeffwan merged commit 350b983 into ray-project:master May 11, 2022
@wilsonwang371 wilsonwang371 deleted the wilson/fix-dup-port branch May 11, 2022 03:27
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@wilsonwang371
Fix duplicated port config and manager.yaml missing config (ray-proje…
4f72c36 
…ct#250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wilsonwang371 @scarlet25151 @Jeffwan