[autoscaler] Make log file mount path more specific. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
|
Extra paranoia --- this Ray PR should also solve the issue: ray-project/ray#26748 |
|
Oh I need to fix the test... |
|
There was an update to the RayJobs CRD when I ran |
I added some comments to the job CRD and forgot to run |
DmitriGekhtman
changed the title
Jeffwan
approved these changes
Jul 20, 2022
that's great! |
scv119
pushed a commit
to ray-project/ray
that referenced
this pull request
Jul 20, 2022
Why are these changes needed? Together with ray-project/kuberay#391, this should address #26064 Have the autoscaler try to make the Ray log directory before setting up logging. ray-project/kuberay#391 should be good enough for this, but this PR makes things safer in case the KubeRay user overrides log mounts or something like that.
4 tasks
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
Why are these changes needed? Together with ray-project/kuberay#391, this should address ray-project#26064 Have the autoscaler try to make the Ray log directory before setting up logging. ray-project/kuberay#391 should be good enough for this, but this PR makes things safer in case the KubeRay user overrides log mounts or something like that. Signed-off-by: Rohan138 <rapotdar@purdue.edu>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Why are these changes needed? Together with ray-project/kuberay#391, this should address ray-project#26064 Have the autoscaler try to make the Ray log directory before setting up logging. ray-project/kuberay#391 should be good enough for this, but this PR makes things safer in case the KubeRay user overrides log mounts or something like that. Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Fix log path. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> * Rerun CI. * Fix test. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> * Rerun CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com
Why are these changes needed?
Should resolve ray-project/ray#26064, where users report the autoscaler crash-looping due to a missing log directory.
Gives the shared log mount configured by the KubeRay operator for Ray logs a more specific path.
(This log mount was introduced in #274)
Previously the path was
/tmp/ray. Instead, we should use/tmp/ray/session_latest/logs, which is where Ray and the autoscaler would like to write logs.By using the more specific path, we ensure that the path will exist on container startup, preventing the file-not-found issues described in ray-project/ray#26064.
Ray attempts to create this directory with
os.makedirs(path, exist_ok=True), so this should not interfere with Ray. (Obviously, this will be confirmed by the tests.)To be extra safe, I'll go ahead and make the autoscaler also
os.makedirs(path, exist_ok=True): ray-project/ray#26748Related issue number
Checks