Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ray-operator documentation and image version in ray-cluster.heterogeneous.yaml #585

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

jasoonn
Copy link
Contributor

@jasoonn jasoonn commented Sep 21, 2022

Why are these changes needed?

The example program doesn't get executed as specified in the readme. This PR updated the readme to give users instructions to execute the example program and show what the result should look like. Besides, this PR upgrades the image to 2.0.0 to allow submitting jobs to Ray cluster, and removes object-manager-port and node-manager-port configuration to avoid port conflicts.

Related issue number

Closes #583

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Ubuntu and others added 2 commits September 21, 2022 18:52
Signed-off-by: jasoonn <35865970+jasoonn@users.noreply.github.com>
@jasoonn jasoonn changed the title Update ray-operator documentation and update image version in ray-cluster.heterogeneous.yaml Update ray-operator documentation and image version in ray-cluster.heterogeneous.yaml Sep 21, 2022
@kevin85421 kevin85421 self-requested a review September 21, 2022 20:55
Signed-off-by: jasoonn <35865970+jasoonn@users.noreply.github.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DmitriGekhtman DmitriGekhtman merged commit 944a042 into ray-project:master Sep 22, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…terogeneous.yaml (ray-project#585)

The example program doesn't get executed as specified in the readme. This PR updated the readme to give users instructions to execute the example program and show what the result should look like. Besides, this PR upgrades the image to 2.0.0 to allow submitting jobs to Ray cluster, and removes object-manager-port and node-manager-port configuration to avoid port conflicts.

Signed-off-by: jasoonn <35865970+jasoonn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Example program doesn't get executed as specified in docs.
3 participants