Remove ray-cluster.without-block.yaml #675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We did not encourage users to run
ray start
without--block
.--block
, we need to appendsleep infinity
to the end of theray start
command to keep the container running.--block
, when the ray process crashes, the KubeRay operator can detect the unhealthy condition in a short time because the container will exit immediately. Without--block
, the unhealthy condition can still be detected by both readiness and liveness probes, but it may take more time to detect it.Note for those who are still interested in ray-cluster.without-block.yaml
There are two bugs in
ray-cluster.without-block.yaml
detected by the configuration test framework #605. See the change ofray-cluster.without-block.yaml
in kevin85421@04bdd77 to fix the bugs.object-manager-port
,node-manager-port
: Update ray-operator documentation and image version in ray-cluster.heterogeneous.yaml #585command
/args
: The original YAML file assumes thatcommand
andargs
will be appended after theray start
command. However, thecommand
andargs
will be executed before theray start
command (See [Feature][Docs] Explain how to specify container command for head pod #651 for more details.). That is, the YAML tries to connect to the Ray cluster before starting the ray cluster.Related issue number
Checks