[Bug] label rayNodeType is useless

[kevin85421]

Why are these changes needed?

Label rayNodeType is useless in the whole KubeRay operator. I guess people are trying to add the label ray.io/node-type which will be set by the Kuberay operator.

kuberay/ray-operator/config/samples/ray-cluster.mini.yaml

Lines 36 to 42 in f3415f4

	metadata:
	labels:
	# custom labels. NOTE: do not define custom labels start with `raycluster.`, they may be used in controller.
	# Refer to https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
	rayCluster: raycluster-sample # will be injected if missing
	rayNodeType: head # will be injected if missing, must be head or wroker
	groupName: headgroup # will be injected if missing

kuberay/ray-operator/controllers/ray/common/constant.go

Line 7 in fd06b5b

RayNodeTypeLabelKey = "ray.io/node-type"

Related issue number

Closes #679

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

• For RayCluster YAMLs in ray-operator/config/samples, I used the configuration test framework to test them.

  cd tests/framework
  python3 test_sample_raycluster_yamls.py 2>&1 | tee log

  

• ray_v1alpha1_rayjob.yaml: I tested it by following the rayjob.md.

• ray_v1alpha1_rayservice.yaml: I tested it by following the rayservice.md. I faced a bug mentioned by a user in KubeRay slack channel (thread) and solved it by setting SERVE_DEPLOYMENT_HANDLE_IS_SYNC (solution from @shrekris-anyscale).

• rayjob_controller_test.go, rayservice_controller_test.go, rayjob_types_test.go, rayservice_types_test.go: Use make build to test them.

• I tested the helm chart.

[kevin85421]

@shrekris-anyscale can you help me review the changes in ray_v1alpha1_rayservice.yaml? Thank you!
@Jeffwan can you help me review the changes in config/prometheus/podMonitor.yaml and docs/guidance/observability.md? I am not familiar with that parts. Thank you!
@DmitriGekhtman can you help me review this PR? Thank you!

[shrekris-anyscale]

Nice work so far! I left a comment for the ray_v1alpha1_rayservice.yaml file.

[Jeffwan]

It looks good to me. Have you check all rayNodeType references? Let's make sure they are totally cleaned up.

[kevin85421]

Have you check all rayNodeType references? Let's make sure they are totally cleaned up.

Thank @Jeffwan for your review! I have checked all occurrences of rayNodeType in KubeRay with the search functionality provided by VSCode. Only pod.go has some variables with the name "rayNodeType" (not pod labels). Thank you!