-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Run config tests with the latest release of KubeRay operator #858
[Feature] Run config tests with the latest release of KubeRay operator #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's remember to remove the extra fields from the sample configs after the next release.
Feel free to merge this.
Thank you for the review! Leave #856 open to tracking the progress. |
ray-project#858) Currently, we only run config tests with the nightly KubeRay operator. However, we also need to keep the compatibility of the current sample YAML files with the latest KubeRay operator release. If not, some bugs may happen (e.g. ray-project#856).
Why are these changes needed?
Currently, we only run config tests with the nightly KubeRay operator. However, we also need to keep the compatibility of the current sample YAML files with the latest KubeRay operator release. If not, some bugs may happen (e.g. #856).
Why do we install the latest release via Helm chart repo?
If we only update the KubeRay operator image to the latest release in the current KubeRay chart, #856 cannot be caught. This is because old CRD defined
serviceType
as a required field and #851 made it optional. Hence, we need to install both CRD and the KubeRay operator with the latest release to catch #856.Why do we test both the nightly operator and the latest release operator in a single GitHub Actions job?
We can parallelize them by dividing them into two GitHub Actions jobs. However, I need to work on a lot with GitHub Actions syntax to reach the goal, and we plan to move KubeRay CI from GitHub Actions to Buildkite soon. Hence, we can parallelize them when we move to the new CI system.
Add serviceType back to sample YAML files.
serviceType
back to sample YAML files (i.e. revert part of [Feature] Make head serviceType optional #851).*.yaml.template
(3 files => only be used in compatibility tests) do not need to revert.Others (This is my personal note. Feel free to ignore this part.)
github.event.pull_request.head.sha
is SHA, but Docker image tag is short SHA.Related issue number
#856 => Close it when the next release is ready and
serviceType
is removed.Closes #857
Checks
Before I add
serviceType
back, #856 is caught by v0.4.0 CRD validation."Sample YAML Config Test - 2.1.0" becomes green when I add
serviceType
back.