Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Run config tests with the latest release of KubeRay operator #858

Merged

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jan 4, 2023

Why are these changes needed?

Currently, we only run config tests with the nightly KubeRay operator. However, we also need to keep the compatibility of the current sample YAML files with the latest KubeRay operator release. If not, some bugs may happen (e.g. #856).

Why do we install the latest release via Helm chart repo?

If we only update the KubeRay operator image to the latest release in the current KubeRay chart, #856 cannot be caught. This is because old CRD defined serviceType as a required field and #851 made it optional. Hence, we need to install both CRD and the KubeRay operator with the latest release to catch #856.

Why do we test both the nightly operator and the latest release operator in a single GitHub Actions job?

We can parallelize them by dividing them into two GitHub Actions jobs. However, I need to work on a lot with GitHub Actions syntax to reach the goal, and we plan to move KubeRay CI from GitHub Actions to Buildkite soon. Hence, we can parallelize them when we move to the new CI system.

Add serviceType back to sample YAML files.

Others (This is my personal note. Feel free to ignore this part.)

github.event.pull_request.head.sha is SHA, but Docker image tag is short SHA.

Related issue number

#856 => Close it when the next release is ready and serviceType is removed.
Closes #857

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Before I add serviceType back, #856 is caught by v0.4.0 CRD validation.

Screen Shot 2023-01-04 at 8 27 04 AM

"Sample YAML Config Test - 2.1.0" becomes green when I add serviceType back.

@kevin85421 kevin85421 changed the title WIP [Feature] Run config tests with the latest release of KubeRay operator Jan 4, 2023
@kevin85421 kevin85421 marked this pull request as ready for review January 4, 2023 17:25
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's remember to remove the extra fields from the sample configs after the next release.

Feel free to merge this.

@kevin85421
Copy link
Member Author

LGTM, let's remember to remove the extra fields from the sample configs after the next release.

Feel free to merge this.

Thank you for the review! Leave #856 open to tracking the progress.

@kevin85421 kevin85421 merged commit 1d3f537 into ray-project:master Jan 5, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
ray-project#858)

Currently, we only run config tests with the nightly KubeRay operator. However, we also need to keep the compatibility of the current sample YAML files with the latest KubeRay operator release. If not, some bugs may happen (e.g. ray-project#856).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Run config tests with the latest release of KubeRay operator
2 participants