Skip to content

Commit

Permalink
[Data] Skip test_client_compat.py::test_client_data_get unit test (#…
Browse files Browse the repository at this point in the history
…41634)

#41466 enables Ray Data streaming executor by default for all datasets. As a result, the Ray Data execution in `test_client_data_get` test is now executed through the streaming executor, which is known to have many incompatibilities since Ray 2.7. So, we skip the test which checks compatibility between Ray Client and Ray Data, until we have a future Ray Client implementation which can better support Ray Data usage.

Signed-off-by: Scott Lee <sjl@anyscale.com>
  • Loading branch information
scottjlee committed Dec 6, 2023
1 parent 003ed1c commit 66365fd
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions python/ray/tests/test_client_compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@
except ImportError:
pyspark = None

from ray._private.test_utils import (
skip_flaky_core_test_premerge,
)


@pytest.mark.skip(
reason=(
"Ray Client not supported with Ray Data streaming execution, "
"which is enabled for all datasets by default in Ray 2.9."
)
)
@pytest.mark.skipif(pyspark is None, reason="PySpark dependency not found")
@pytest.mark.parametrize(
"call_ray_start",
Expand All @@ -22,7 +24,6 @@
],
indirect=True,
)
@skip_flaky_core_test_premerge("https://github.com/ray-project/ray/issues/41620")
def test_client_data_get(call_ray_start):
"""PySpark import changes NamedTuple pickling behavior, leading
to inconpatibilities with the Ray client and Ray Data. This test
Expand Down

0 comments on commit 66365fd

Please sign in to comment.