[Tune] logger.py: Relax TBX Summary ValueErrors with e.g. empty lists…

… in lists (and all… (#6987)
ray-project · Feb 5, 2020 · 93ed86f · 93ed86f
1 parent 0e39608
commit 93ed86f
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/python/ray/tune/logger.py b/python/ray/tune/logger.py
@@ -350,6 +350,7 @@ def on_result(self, result):
         flat_result = flatten_dict(tmp, delimiter="/")
         path = ["ray", "tune"]
         valid_result = {}
+
         for attr, value in flat_result.items():
             full_attr = "/".join(path + [attr])
             if type(value) in VALID_SUMMARY_TYPES:
@@ -358,8 +359,16 @@ def on_result(self, result):
                     full_attr, value, global_step=step)
             elif type(value) is list and len(value) > 0:
                 valid_result[full_attr] = value
-                self._file_writer.add_histogram(
-                    full_attr, value, global_step=step)
+                try:
+                    self._file_writer.add_histogram(
+                        full_attr, value, global_step=step)
+                # In case TensorboardX still doesn't think it's a valid value
+                # (e.g. `[[]]`), warn and move on.
+                except ValueError:
+                    logger.warning(
+                        "You are trying to log an invalid value ({}={}) "
+                        "via {}!".format(full_attr, value,
+                                         type(self).__name__))
 
         self.last_result = valid_result
         self._file_writer.flush()