Skip to content

Commit

Permalink
Relink grpc/absl for streaming.so (#20136)
Browse files Browse the repository at this point in the history
To avoid exporting thrirdparty library symbol globally, these absl/grpc libs have been applied in _streaming.so.

Side-effect:
Static variables might be uninitialized if core worker lib and streaming lib both use them.
  • Loading branch information
ashione committed Nov 9, 2021
1 parent 5c4fb4d commit 97259e3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
6 changes: 6 additions & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2201,6 +2201,12 @@ pyx_library(
),
deps = [
"//streaming:streaming_lib",
"@com_github_grpc_grpc//:grpc++",
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/memory",
"@com_google_absl//absl/synchronization",
"@com_google_absl//absl/time",
],
)

Expand Down
4 changes: 1 addition & 3 deletions src/ray/ray_exported_symbols.lds
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,4 @@
*JNI_*
*ray*streaming*
*aligned_free*
*aligned_malloc*
*absl*
*grpc*
*aligned_malloc*
1 change: 0 additions & 1 deletion src/ray/ray_version_script.lds
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,5 @@ VERSION_1.0 {
*ray*streaming*;
*aligned_free*;
*aligned_malloc*;
*grpc*;
local: *;
};

0 comments on commit 97259e3

Please sign in to comment.