-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rllib] Improve model config documentation #2538
Comments
Would you mind submitting any quick fixes as a PR? Note that in general for customizations it's better to just write a custom model instead, it amounts to copying the model source code and registering it. The amount of stuff we can support in a config is limited. |
Related question on SO:
"For the (6,94) case, is the "dim" supposed to be 6 or 94? Is the conv_filters fine leaving as is, or is a certain network architecture necessary for each shape? If so, where is the link?" |
I'm having the same issue here:
|
You can force using a fcnet as the custom model, or flatten your
observation. It's trying to create a convnet over the inputs and getting
confused about the shape.
…On Sun, Aug 18, 2019, 6:44 PM D Schulz ***@***.***> wrote:
I'm having the same issue here:
ValueError: No default configuration for obs shape [1, 5], you must specify `conv_filters` manually as a model option. Default configurations are only available for inputs of shape [42, 42, K] and [84, 84, K]. You may alternatively want to use a custom model or preprocessor.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2538?email_source=notifications&email_token=AAADUSWJKZD7H6HXSCGEVR3QFER2JA5CNFSM4FNNSO7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Q5HCI#issuecomment-522310537>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAADUSQ42YIJ7TFNX5SUHH3QFER2JANCNFSM4FNNSO7A>
.
|
I've been trying to use the model config as much as possible to avoid writing custom models, but often the documentation is difficult to understand.
For example, to understand the
conv_filters
option, the documentation says that the model config is documented in the model catalog. In the source code, the model catalog documentation forconv_filters
says"conv_filters", # Filter configuration
. I had to grep the source code before finding out thatconv_filters
is a list of[out_channels, kernel, stride]
from visionnet.py.The text was updated successfully, but these errors were encountered: