-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] Initial API deprecations for Ray 1.0 #10325
Conversation
@@ -161,6 +161,7 @@ async def test_shard_key(serve_instance, task_runner_mock_actor): | |||
assert call.request_args[0] in runner_shard_keys[i] | |||
|
|||
|
|||
# TODO(fix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it ASAP. on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's gone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catharsis is real! We should publish a summary of all of the breaking changes that are being made when we release 1.0.
I just realized that |
Looks like just 1 tune test failed; merging to unblock followup prs. |
Why are these changes needed?
Initial set of API changes for Ray 1.0, focusing on the core Ray APIs. Some of these parameter removals are breaking changes, but none of them should be particularly impactful.
Planning spreadsheet:
https://docs.google.com/spreadsheets/d/1F6VZ1R_fgDzpRZjXI5_6gaUwW2CQKi431dCDTR-Vm8s/edit#gid=0