[Serve] Define Java Backend #16169
[Serve] Define Java Backend #16169
Conversation
liuyang-my
added
enhancement
| import java.io.Serializable; | ||
| import org.apache.commons.lang3.builder.ReflectionToStringBuilder; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Let's make sure to convert this into protobuf in the next PR?
There was a problem hiding this comment.
Yes. I'll design some plans about next PR this week.
|
|
||
| this.hostActor = hostActor; | ||
| this.keyListeners = keyListeners; | ||
| this.snapshotIds = new ConcurrentHashMap<>(); |
|
I think there are several format and lint issues, Additionally, are these tests ran at all? Can you try add them to https://github.com/ray-project/ray/blob/master/java/test.sh |
|
@liuyang-my ping about adding the tests. Thanks! |
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>27.0.1-jre</version> |
There was a problem hiding this comment.
Unfortunately, we had upgraded guava to 30.0 to fix CVEs. The PR is #16650
There was a problem hiding this comment.
@liuyang-my Can you also fix it?
Why are these changes needed?
We hope to take Ray Serve to AntGroup and reuse the ability of Ray Serve in Ant's Ray Serving. In Ant, a large part of business scenarios come from Java developers, so Ray Serve is required to support Java backend.
In the milestone "[serve] Support Java Backend", we will enable Ray Serve to support Java Backend. Detailed design is in doc :https://docs.google.com/document/d/1b9VCZsC2jVhWw_c_ifMu_ED3NxkARcOnU-OFqUYu-r4/edit#heading=h.b3vvz7iwnixn
This PR is about the definition of Java Backend.
Related issue number
#15835
Checks
scripts/format.shto lint the changes in this PR.