-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Another attempt at building Python 3.9 MacOS wheels #16347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, let's wait until morning to merge it though, since the other attempts also looked fine until they broke master 😛
Fixed an issue in |
crossing fingers and merging now 🤞 |
This might've worked? There were some travis CI issues today, so we're 1/2 on the mac wheel builds. The failed build was due to a timeout (this also happened before thought). I'm cautiously excited, but we may need to make sure the mac wheel build doesn't timeout too often. |
Yes, I hope it works too! From my observation, it seems every time we run out then refill Travis credits, all Bazel deps are rebuilt which can longer time. Hopefully we will see faster Mac builds tonight! |
* Test rollforward python 3.9 * Upgrade setproctitle in thirdparty * Update cython requirement to match those in wheel build scripts. * Fix MANIFEST.in * Fix file copying in setup.py
Why are these changes needed?
I was able to reproduce the issue of Python 3.9 wheels missing
ray/python/ray/thirdparty_files
on my MacBook. IIUC, the file copying logic inpython/setup.py
is broken in some cases. Logic indistutils.build_ext
actually copied thepsutil
andsetproctitle
files. This behavior could have changed on MacOS Python 3.9, for these types of files. Fixing the logic insetup.py
seem to fix the issue.A more radical approach would be to not vendor
psutil
andsetproctitle
anymore, and require users to install themselves as Python dependencies. If Ray C++ uses these libraries, they could (might already?) be statically linked.Related issue number
#11287
Checks
scripts/format.sh
to lint the changes in this PR.