Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler][gcp] Retry GCP BrokenPipeError #16952

Merged
merged 10 commits into from
Jul 8, 2021

Conversation

DmitriGekhtman
Copy link
Contributor

@DmitriGekhtman DmitriGekhtman commented Jul 8, 2021

Why are these changes needed?

Closes #16072

Follows closely the strategy of kubeflow/pipelines#5250
On BrokenPipeError, retry and reconstruct google compute client.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Unit test for retry logic. Manual test with ray up to make sure nothing broke.

@DmitriGekhtman DmitriGekhtman changed the title [autoscaler][gcp] Retry GCP BrokenPipeErrors [autoscaler][gcp] Retry GCP BrokenPipeError Jul 8, 2021
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! I really like this test! It is thorough and gives confidence that the wrapper works as intended!

@DmitriGekhtman
Copy link
Contributor Author

LGTM now! I really like this test! It is thorough and gives confidence that the wrapper works as intended!

Thanks!
The test gives me confidence that a random blip in my attention span didn't destroy Ray's GCP support.

@ijrsvt
Copy link
Contributor

ijrsvt commented Jul 8, 2021

Windows failure is object spilling and thus unrelated.
Mac failures are also unrelated (not autoscaler related).

@ijrsvt ijrsvt merged commit 27a9ae5 into ray-project:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoscaler][gcp][default] Autoscaler throws BrokenPipeError on gcp.
3 participants