-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): add bypass for BrokenPipeError in gcp ml engine client. Fixes #5085 #5250
fix(components): add bypass for BrokenPipeError in gcp ml engine client. Fixes #5085 #5250
Conversation
Hi @dkajtoch. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @hongye-sun |
/lgtm |
@Ark-kun do you need any input from my side in this PR? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
something failed and I am not sure if I can access logs of the container |
/retest |
Description of your changes:
Add bypass to fix recurring problems with BrokenPipeError in MLEngineClient class. It works in my custom build container and I am able to train models on ml engine without problems (only seeing warning from retry decorator). I on purpose name it "bypass" since it does not solve the root of the problem that seems to exist since 2016: googleapis/google-api-python-client#218
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.