Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): add bypass for BrokenPipeError in gcp ml engine client. Fixes #5085 #5250

Conversation

dkajtoch
Copy link
Contributor

@dkajtoch dkajtoch commented Mar 5, 2021

Description of your changes:
Add bypass to fix recurring problems with BrokenPipeError in MLEngineClient class. It works in my custom build container and I am able to train models on ml engine without problems (only seeing warning from retry decorator). I on purpose name it "bypass" since it does not solve the root of the problem that seems to exist since 2016: googleapis/google-api-python-client#218

Checklist:

@google-oss-robot
Copy link

Hi @dkajtoch. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dkajtoch
Copy link
Contributor Author

dkajtoch commented Mar 5, 2021

/assign @hongye-sun

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 18, 2021

/lgtm
/ok-to-test

@dkajtoch
Copy link
Contributor Author

@Ark-kun do you need any input from my side in this PR?

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 4, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkajtoch
Copy link
Contributor Author

dkajtoch commented Apr 4, 2021

something failed and I am not sure if I can access logs of the container

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 5, 2021

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants