[Hotfix] Pin node version to 14 #19522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdeng
reviewed
Oct 19, 2021
| @@ -257,7 +257,9 @@ build_dashboard_front_end() { | |||
| if [ -z "${BUILDKITE-}" ] || [[ "${OSTYPE}" != linux* ]]; then | |||
| set +x # suppress set -x since it'll get very noisy here | |||
| . "${HOME}/.nvm/nvm.sh" | |||
| nvm use --silent node | |||
| NODE_VERSION="14" | |||
There was a problem hiding this comment.
Out of curiosity, why pin this to 14 and not 16? Were we not using 16 before 17 was released?
There was a problem hiding this comment.
oh it's just i know 14 works because it's pinned in one of the build but not others
matthewdeng
approved these changes
Oct 19, 2021
simon-mo
added a commit
that referenced
this pull request
Oct 19, 2021
gjoliver
pushed a commit
that referenced
this pull request
Oct 20, 2021
simon-mo
added a commit
that referenced
this pull request
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.