Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] add comment for waiting for Ray to shutdown in test_client_reconnect.py #21672

Merged
merged 1 commit into from
Jan 18, 2022
Merged

[Doc] add comment for waiting for Ray to shutdown in test_client_reconnect.py #21672

merged 1 commit into from
Jan 18, 2022

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Jan 18, 2022

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone fishbone merged commit ef9d9df into ray-project:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckw017 ckw017 ckw017 approved these changes

@fishbone fishbone fishbone approved these changes

Assignees

@ckw017 ckw017

@fishbone fishbone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwtian @ckw017 @fishbone