Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaWorker] Java code lint check and binding to CI #2225

Merged
merged 3 commits into from Jun 9, 2018

Conversation

salah-man
Copy link
Contributor

. Use the maven-checkstyle-plugin for java code lint check and Google Style for the rules, which is almost the same as Apache Arrow.
. Fix the java code lint problem in the whole java package.
. Add the java code lint check in CI.

@salah-man salah-man mentioned this pull request Jun 9, 2018
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5966/
Test PASSed.

Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! All the changes in this PR are just linting related, right? I checked some of it but not all.

@robertnishihara
Copy link
Collaborator

Thanks @salah-man!

@salah-man
Copy link
Contributor Author

Yes,it is all the changes of this PR is about java code lint and all of the changed files are under the java package.

@pcmoritz pcmoritz merged commit 3b5e700 into ray-project:master Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants