Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[serve] Add basic REST API to dashboard" #22414

Merged
merged 1 commit into from Feb 16, 2022

Conversation

architkulkarni
Copy link
Contributor

Reverts #2225
Screen Shot 2022-02-15 at 6 31 58 PM

Seems to have broken linux://python/ray/workflow:tests/test_basic_workflows_2

Anecdotally, I started consistently getting this error with ray start --head roughly around the time of this PR being merged:

❯ ray start --head
Local node IP: 127.0.0.1
2022-02-15 18:29:31,278 ERROR services.py:1508 -- Failed to start the dashboard: Failed to start the dashboard, return code 1
 The last 10 lines of /tmp/ray/session_2022-02-15_18-29-29_064188_4744/logs/dashboard.log:
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/sessions.py", line 542, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/sessions.py", line 655, in send
    r = adapter.send(request, **kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='127.0.0.1', port=8265): Max retries exceeded with url: /api/jobs/submit (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fbae5e547f0>: Failed to establish a new connection: [Errno 61] Connection refused'))
2022-02-15 18:29:31,279 ERROR services.py:1509 -- Failed to start the dashboard, return code 1
 The last 10 lines of /tmp/ray/session_2022-02-15_18-29-29_064188_4744/logs/dashboard.log:
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/sessions.py", line 542, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/sessions.py", line 655, in send
    r = adapter.send(request, **kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='127.0.0.1', port=8265): Max retries exceeded with url: /api/jobs/submit (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fbae5e547f0>: Failed to establish a new connection: [Errno 61] Connection refused'))
Traceback (most recent call last):
  File "/Users/archit/ray/python/ray/_private/services.py", line 1485, in start_dashboard
    raise Exception(err_msg + last_log_str)
Exception: Failed to start the dashboard, return code 1
 The last 10 lines of /tmp/ray/session_2022-02-15_18-29-29_064188_4744/logs/dashboard.log:
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/sessions.py", line 542, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/sessions.py", line 655, in send
    r = adapter.send(request, **kwargs)
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/site-packages/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='127.0.0.1', port=8265): Max retries exceeded with url: /api/jobs/submit (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fbae5e547f0>: Failed to establish a new connection: [Errno 61] Connection refused'))

@edoakes
Copy link
Contributor

edoakes commented Feb 16, 2022

Reverting w/o waiting for CI since pure revert

@edoakes edoakes merged commit 63a5eb4 into master Feb 16, 2022
@edoakes edoakes deleted the revert-22257-basic-serve-rest-api branch February 16, 2022 03:47
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants