[serve] Create deployment.py and deployment_graph.py
#23578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekris-anyscale
changed the title
deployment.py and deployment_graph.pydeployment.py and deployment_graph.py
edoakes
reviewed
Mar 31, 2022
Good catch– I updated |
edoakes
approved these changes
Apr 1, 2022
|
Suspicious test failure, rerunning |
3 tasks
edoakes
pushed a commit
that referenced
this pull request
May 10, 2022
…` functions (#24616) There are delayed imports in the [`run()`](https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py#L596-L597) and [`build()`](https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py#L672) functions in [`api.py`](https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py). These imports are no longer circular due to recent refactoring (see #23578 and #23759). This change promotes them to top-level imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
api.pyhas accumulated classes and functions that aren't purely public APIs, causing circular dependencies. This change pullsDeploymentand deployment graph-related features out ofapi.pyand puts them in two new files:deployment.pyanddeployment_graph.py.Related issue number
N/A
Checks
scripts/format.shto lint the changes in this PR.