[serve] Create application.py
#23759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
Apr 6, 2022
poquetlpnb
approved these changes
Apr 7, 2022
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Apr 7, 2022
The `Application` class is stored in `api.py`. The object is relatively standalone and is used as a dependency in other classes, so this change moves `Application` (and `ImmutableDeploymentDict`) to a new file, `application.py`.
clarkzinzow
added a commit
to clarkzinzow/ray
that referenced
this pull request
Apr 7, 2022
This reverts commit a6bcb6c.
3 tasks
edoakes
pushed a commit
that referenced
this pull request
May 10, 2022
…` functions (#24616) There are delayed imports in the [`run()`](https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py#L596-L597) and [`build()`](https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py#L672) functions in [`api.py`](https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py). These imports are no longer circular due to recent refactoring (see #23578 and #23759). This change promotes them to top-level imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
Applicationclass is stored inapi.py. The object is relatively standalone and is used as a dependency in other classes, so this change movesApplication(andImmutableDeploymentDict) to a new file,application.py.Related issue number
N/A
Checks
scripts/format.shto lint the changes in this PR.